]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commitdiff
brcmfmac: Fix hex dump for FWIL.
authorHante Meuleman <meuleman@broadcom.com>
Thu, 12 Dec 2013 10:59:01 +0000 (11:59 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 18 Dec 2013 20:22:51 +0000 (15:22 -0500)
The debug function brcmf_dbg_hex_dump API got changed and the
information string should preferably contain a \n at the end
of the string. Update the FWIL so debug output looks better.

Reviewed-by: Arend Van Spriel <arend@broadcom.com>
Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Hante Meuleman <meuleman@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/brcm80211/brcmfmac/fwil.c

index b72d3395499a3c1e713af54a4379f86e93ca407a..22adbe311d206df979a592419d7d247280474ec6 100644 (file)
@@ -68,7 +68,7 @@ brcmf_fil_cmd_data_set(struct brcmf_if *ifp, u32 cmd, void *data, u32 len)
 
        brcmf_dbg(FIL, "cmd=%d, len=%d\n", cmd, len);
        brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data,
-                          min_t(uint, len, MAX_HEX_DUMP_LEN), "data");
+                          min_t(uint, len, MAX_HEX_DUMP_LEN), "data\n");
 
        err = brcmf_fil_cmd_data(ifp, cmd, data, len, true);
        mutex_unlock(&ifp->drvr->proto_block);
@@ -86,7 +86,7 @@ brcmf_fil_cmd_data_get(struct brcmf_if *ifp, u32 cmd, void *data, u32 len)
 
        brcmf_dbg(FIL, "cmd=%d, len=%d\n", cmd, len);
        brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data,
-                          min_t(uint, len, MAX_HEX_DUMP_LEN), "data");
+                          min_t(uint, len, MAX_HEX_DUMP_LEN), "data\n");
 
        mutex_unlock(&ifp->drvr->proto_block);
 
@@ -155,7 +155,7 @@ brcmf_fil_iovar_data_set(struct brcmf_if *ifp, char *name, void *data,
 
        brcmf_dbg(FIL, "name=%s, len=%d\n", name, len);
        brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data,
-                          min_t(uint, len, MAX_HEX_DUMP_LEN), "data");
+                          min_t(uint, len, MAX_HEX_DUMP_LEN), "data\n");
 
        buflen = brcmf_create_iovar(name, data, len, drvr->proto_buf,
                                    sizeof(drvr->proto_buf));
@@ -195,7 +195,7 @@ brcmf_fil_iovar_data_get(struct brcmf_if *ifp, char *name, void *data,
 
        brcmf_dbg(FIL, "name=%s, len=%d\n", name, len);
        brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data,
-                          min_t(uint, len, MAX_HEX_DUMP_LEN), "data");
+                          min_t(uint, len, MAX_HEX_DUMP_LEN), "data\n");
 
        mutex_unlock(&drvr->proto_block);
        return err;
@@ -278,7 +278,7 @@ brcmf_fil_bsscfg_data_set(struct brcmf_if *ifp, char *name,
 
        brcmf_dbg(FIL, "bssidx=%d, name=%s, len=%d\n", ifp->bssidx, name, len);
        brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data,
-                          min_t(uint, len, MAX_HEX_DUMP_LEN), "data");
+                          min_t(uint, len, MAX_HEX_DUMP_LEN), "data\n");
 
        buflen = brcmf_create_bsscfg(ifp->bssidx, name, data, len,
                                     drvr->proto_buf, sizeof(drvr->proto_buf));
@@ -317,7 +317,7 @@ brcmf_fil_bsscfg_data_get(struct brcmf_if *ifp, char *name,
        }
        brcmf_dbg(FIL, "bssidx=%d, name=%s, len=%d\n", ifp->bssidx, name, len);
        brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data,
-                          min_t(uint, len, MAX_HEX_DUMP_LEN), "data");
+                          min_t(uint, len, MAX_HEX_DUMP_LEN), "data\n");
 
        mutex_unlock(&drvr->proto_block);
        return err;