]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
staging: iio: adt7316: remove dac vref buffer bypass from adt751x
authorJeremy Fertic <jeremyfertic@gmail.com>
Wed, 12 Dec 2018 00:55:01 +0000 (17:55 -0700)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 16 Dec 2018 14:05:55 +0000 (14:05 +0000)
The option to allow the external vref to bypass the reference buffer is
only available for adt7316/7/8. Remove the attributes for adt751x as
well as the chip->id checks from the show and store functions.

Signed-off-by: Jeremy Fertic <jeremyfertic@gmail.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/staging/iio/addac/adt7316.c

index ab6de60a94ae654088be006a6055d227f129ec44..0ee925edad0425495076755f5de436c8b206a84c 100644 (file)
@@ -969,9 +969,6 @@ static ssize_t adt7316_show_DA_AB_Vref_bypass(struct device *dev,
        struct iio_dev *dev_info = dev_to_iio_dev(dev);
        struct adt7316_chip_info *chip = iio_priv(dev_info);
 
-       if ((chip->id & ID_FAMILY_MASK) == ID_ADT75XX)
-               return -EPERM;
-
        return sprintf(buf, "%d\n",
                !!(chip->dac_config & ADT7316_VREF_BYPASS_DAC_AB));
 }
@@ -986,9 +983,6 @@ static ssize_t adt7316_store_DA_AB_Vref_bypass(struct device *dev,
        u8 dac_config;
        int ret;
 
-       if ((chip->id & ID_FAMILY_MASK) == ID_ADT75XX)
-               return -EPERM;
-
        dac_config = chip->dac_config & (~ADT7316_VREF_BYPASS_DAC_AB);
        if (buf[0] == '1')
                dac_config |= ADT7316_VREF_BYPASS_DAC_AB;
@@ -1014,9 +1008,6 @@ static ssize_t adt7316_show_DA_CD_Vref_bypass(struct device *dev,
        struct iio_dev *dev_info = dev_to_iio_dev(dev);
        struct adt7316_chip_info *chip = iio_priv(dev_info);
 
-       if ((chip->id & ID_FAMILY_MASK) == ID_ADT75XX)
-               return -EPERM;
-
        return sprintf(buf, "%d\n",
                !!(chip->dac_config & ADT7316_VREF_BYPASS_DAC_CD));
 }
@@ -1031,9 +1022,6 @@ static ssize_t adt7316_store_DA_CD_Vref_bypass(struct device *dev,
        u8 dac_config;
        int ret;
 
-       if ((chip->id & ID_FAMILY_MASK) == ID_ADT75XX)
-               return -EPERM;
-
        dac_config = chip->dac_config & (~ADT7316_VREF_BYPASS_DAC_CD);
        if (buf[0] == '1')
                dac_config |= ADT7316_VREF_BYPASS_DAC_CD;
@@ -1710,8 +1698,6 @@ static struct attribute *adt7516_attributes[] = {
        &iio_dev_attr_DAC_update_mode.dev_attr.attr,
        &iio_dev_attr_all_DAC_update_modes.dev_attr.attr,
        &iio_dev_attr_update_DAC.dev_attr.attr,
-       &iio_dev_attr_DA_AB_Vref_bypass.dev_attr.attr,
-       &iio_dev_attr_DA_CD_Vref_bypass.dev_attr.attr,
        &iio_dev_attr_DAC_internal_Vref.dev_attr.attr,
        &iio_dev_attr_VDD.dev_attr.attr,
        &iio_dev_attr_in_temp.dev_attr.attr,