]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
drm/exynos: fix drm driver de-initialization order
authorAndrzej Hajda <a.hajda@samsung.com>
Tue, 9 Sep 2014 13:16:06 +0000 (15:16 +0200)
committerInki Dae <daeinki@gmail.com>
Fri, 19 Sep 2014 15:56:14 +0000 (00:56 +0900)
Since components have their own cleanup routines calling
drm_mode_config_cleanup before component_unbind_all causes errors
due to double free of KMS objects. The patch fixes it by changing
de-initialization order. Now it is exactly opposite to init order.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
drivers/gpu/drm/exynos/exynos_drm_drv.c

index 3f6ec9670659310fbb86acd296f5964f3e7e811d..9b00e4ecdb3accd891bfb3770fb48fae5cb8f0ed 100644 (file)
@@ -136,14 +136,14 @@ static int exynos_drm_unload(struct drm_device *dev)
        exynos_drm_device_subdrv_remove(dev);
 
        exynos_drm_fbdev_fini(dev);
-       drm_vblank_cleanup(dev);
        drm_kms_helper_poll_fini(dev);
-       drm_mode_config_cleanup(dev);
 
+       component_unbind_all(dev->dev, dev);
+       drm_vblank_cleanup(dev);
+       drm_mode_config_cleanup(dev);
        drm_release_iommu_mapping(dev);
-       kfree(dev->dev_private);
 
-       component_unbind_all(dev->dev, dev);
+       kfree(dev->dev_private);
        dev->dev_private = NULL;
 
        return 0;