prevent visual flashing of button when changing element in the tree

when changing between elements in the tree, either the
start or shutdown buttons were visually flashing (meaning they are
enabled/disabled for a short time and change state shortly after)

this patch fixes that

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Acked-by: Emmanuel Kasper <e.kasper@proxmox.com>

diff --git a/www/manager6/lxc/Config.js b/www/manager6/lxc/Config.js
index 7a735cd63eead1ec679e24a3b453b15794eab4ba..0ffc4841ed8e4f924121e78906016696599628d8 100644 (file)
--- a/www/manager6/lxc/Config.js
+++ b/www/manager6/lxc/Config.js
@@ -19,6 +19,8 @@ Ext.define('PVE.lxc.Config', {
 
        var template = me.pveSelNode.data.template;
 
+       var running = !!me.pveSelNode.data.uptime;
+
        var caps = Ext.state.Manager.get('GuiCap');
 
        var base_url = '/nodes/' + nodename + '/lxc/' + vmid;
@@ -42,7 +44,7 @@ Ext.define('PVE.lxc.Config', {
 
        var startBtn = Ext.create('Ext.Button', {
            text: gettext('Start'),
-           disabled: !caps.vms['VM.PowerMgmt'],
+           disabled: !caps.vms['VM.PowerMgmt'] || running,
            handler: function() {
                vm_command('start');
            },
@@ -62,7 +64,7 @@ Ext.define('PVE.lxc.Config', {
 
        var shutdownBtn = Ext.create('PVE.button.Split', {
            text: gettext('Shutdown'),
-           disabled: !caps.vms['VM.PowerMgmt'],
+           disabled: !caps.vms['VM.PowerMgmt'] || !running,
            confirmMsg: PVE.Utils.format_task_description('vzshutdown', vmid),
            handler: function() {
                vm_command('shutdown');

diff --git a/www/manager6/qemu/Config.js b/www/manager6/qemu/Config.js
index f36ba690b1ff8724c3c1d1eb73e2ecaffe73e4fa..db0f3152c587d6de8bae32b97ac2763899974e40 100644 (file)
--- a/www/manager6/qemu/Config.js
+++ b/www/manager6/qemu/Config.js
@@ -19,6 +19,8 @@ Ext.define('PVE.qemu.Config', {
 
        var template = !!me.pveSelNode.data.template;
 
+       var running = !!me.pveSelNode.data.uptime;
+
        var caps = Ext.state.Manager.get('GuiCap');
 
        var base_url = '/nodes/' + nodename + "/qemu/" + vmid;
@@ -52,7 +54,7 @@ Ext.define('PVE.qemu.Config', {
 
        var startBtn = Ext.create('Ext.Button', {
            text: gettext('Start'),
-           disabled: !caps.vms['VM.PowerMgmt'],
+           disabled: !caps.vms['VM.PowerMgmt'] || running,
            hidden: template,
            handler: function() {
                vm_command('start');
@@ -133,7 +135,7 @@ Ext.define('PVE.qemu.Config', {
 
        var shutdownBtn = Ext.create('PVE.button.Split', {
            text: gettext('Shutdown'),
-           disabled: !caps.vms['VM.PowerMgmt'],
+           disabled: !caps.vms['VM.PowerMgmt'] || !running,
            hidden: template,
            confirmMsg: PVE.Utils.format_task_description('qmshutdown', vmid),
            handler: function() {