]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
RDMA/core: Add missing list deletion on freeing event queue
authorMichael Guralnik <michaelgur@mellanox.com>
Wed, 12 Feb 2020 07:26:31 +0000 (09:26 +0200)
committerJason Gunthorpe <jgg@mellanox.com>
Thu, 13 Feb 2020 13:44:49 +0000 (09:44 -0400)
When the uobject file scheme was revised to allow device disassociation
from the file it became possible for read() to still happen the driver
destroys the uobject.

The old clode code was not tolerant to concurrent read, and when it was
moved to the driver destroy it creates a bug.

Ensure the event_list is empty after driver destroy by adding the missing
list_del(). Otherwise read() can trigger a use after free and double
kfree.

Fixes: f7c8416ccea5 ("RDMA/core: Simplify destruction of FD uobjects")
Link: https://lore.kernel.org/r/20200212072635.682689-6-leon@kernel.org
Signed-off-by: Michael Guralnik <michaelgur@mellanox.com>
Reviewed-by: Yishai Hadas <yishaih@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/core/uverbs_std_types.c

index 994d8744b246921ea1c3f0b89a159d621acebecf..3abfc63225cbfa24aea4c991d808b355a21eb0f9 100644 (file)
@@ -220,6 +220,7 @@ void ib_uverbs_free_event_queue(struct ib_uverbs_event_queue *event_queue)
        list_for_each_entry_safe(entry, tmp, &event_queue->event_list, list) {
                if (entry->counter)
                        list_del(&entry->obj_list);
+               list_del(&entry->list);
                kfree(entry);
        }
        spin_unlock_irq(&event_queue->lock);