]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
fib: remove a useless synchronize_rcu() call
authorEric Dumazet <eric.dumazet@gmail.com>
Wed, 13 Oct 2010 04:43:04 +0000 (04:43 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sat, 16 Oct 2010 18:13:22 +0000 (11:13 -0700)
fib_nl_delrule() calls synchronize_rcu() for no apparent reason,
while rtnl is held.

I suspect it was done to avoid an atomic_inc_not_zero() in
fib_rules_lookup(), which commit 7fa7cb7109d07 added anyway.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/fib_rules.c

index 21698f8c49ee7a7c0590fc38ab28e4ad7afaf1fd..1bc3f253ba6c76efe7e8b97c78c2e6a72d771b23 100644 (file)
@@ -494,7 +494,6 @@ static int fib_nl_delrule(struct sk_buff *skb, struct nlmsghdr* nlh, void *arg)
                        }
                }
 
-               synchronize_rcu();
                notify_rule_change(RTM_DELRULE, rule, ops, nlh,
                                   NETLINK_CB(skb).pid);
                fib_rule_put(rule);