pct exec: do running check earlier

So that both VMID and state related checks are grouped together.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>

diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm
index 0211bee2fa3f79032db0caa546ee6653e786abce..0e00b310aeb3699f00f659fa3a8db50c5433c394 100755 (executable)
--- a/src/PVE/CLI/pct.pm
+++ b/src/PVE/CLI/pct.pm
@@ -184,12 +184,10 @@ __PACKAGE__->register_method ({
 
        my $vmid = $param->{vmid};
        PVE::LXC::Config->load_config($vmid); # test if container exists on this node
-
-       if (!@{$param->{'extra-args'}}) {
-           die "missing command";
-       }
        die "Error: container '$vmid' not running!\n" if !PVE::LXC::check_running($vmid);
 
+       die "missing command" if !@{$param->{'extra-args'}};
+
        exec('lxc-attach', '-n', $vmid, '--', @{$param->{'extra-args'}});
     }});