systemd-fsckd autopkgtest: Stop using/asserting on lightdm

Just check that default.target is active. lightdm is prone to fail in test
environments, and fiddling with it in two other autopkgtests is sufficient.

diff --git a/debian/changelog b/debian/changelog
index bfc927cca66d9b7c03683154a460cbf1bf535409..85342cda39e8f56e9f490468a520535cf375c8d5 100644 (file)
--- a/debian/changelog
+++ b/debian/changelog
@@ -14,6 +14,10 @@ systemd (221-2) UNRELEASED; urgency=medium
     the link check, to also avoid libeatmydata. (Closes: #790546)
   * boot-and-services, display-managers autopkgtests: Install and configure
     dummy X.org driver, so that these work in headless machines/VMs.
+  * systemd-fsckd autopkgtest: Stop using/asserting on lightdm, just check
+    that default.target is active. lightdm is prone to fail in test
+    environments, and fiddling with it in two other autopkgtests is
+    sufficient.
 
  -- Martin Pitt <mpitt@debian.org>  Mon, 29 Jun 2015 07:42:50 +0200
 

diff --git a/debian/tests/control b/debian/tests/control
index 8d9e20c8e792f95dfda59e8405aa047d55a528a6..528e764766cff41821af1a3e2d8d78f3eec7a8d3 100644 (file)
--- a/debian/tests/control
+++ b/debian/tests/control
@@ -42,5 +42,5 @@ Depends: systemd-sysv, network-manager, policykit-1, lightdm
 Restrictions: needs-recommends, needs-root, isolation-container, allow-stderr
 
 Tests: systemd-fsckd
-Depends: systemd, systemd-sysv, python3, lightdm, plymouth
+Depends: systemd-sysv, python3, plymouth
 Restrictions: needs-root, isolation-machine, needs-recommends, breaks-testbed

diff --git a/debian/tests/systemd-fsckd b/debian/tests/systemd-fsckd
index 7b40de4362c1b68007416554805695dba0c998c6..ba26085e4289150b9b0f2b643222abc11ded68aa 100755 (executable)
--- a/debian/tests/systemd-fsckd
+++ b/debian/tests/systemd-fsckd
@@ -186,12 +186,9 @@ class FsckdTest(unittest.TestCase):
             self.assertFalse(self.was_running('plymouth-start'))
 
     def assertSystemRunning(self):
-        '''Assert we started lightdm and xorg (and so, consider the system running)'''
-        out = subprocess.check_output(['ps', 'u', '-C', 'lightdm'])
-        self.assertIn(b'lightdm --session', out)
-        out = subprocess.check_output(['ps', 'u', '-C', 'Xorg'])
-        self.assertIn(b':0', out)
-        self.assertTrue(self.is_active_unit('lightdm'))
+        '''Assert that the system is running'''
+
+        self.assertTrue(self.is_active_unit('default.target'))
 
     def assertProcessKilled(self):
         '''Assert the targeted process was killed successfully'''