]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
ARM: dts: exynos: correct TMU phandle in Odroid XU3 family
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thu, 9 Feb 2023 10:58:41 +0000 (11:58 +0100)
committerAndrea Righi <andrea.righi@canonical.com>
Tue, 14 Mar 2023 15:47:35 +0000 (16:47 +0100)
BugLink: https://bugs.launchpad.net/bugs/2011425
commit a3583e92d188ec6c58c7f603ac5e72dd8a11c21a upstream.

TMU node uses 0 as thermal-sensor-cells, thus thermal zone referencing
it must not have an argument to phandle.  This was not critical before,
but since rework of thermal Devicetree initialization in the
commit 3fd6d6e2b4e8 ("thermal/of: Rework the thermal device tree
initialization"), this leads to errors registering thermal zones other
than first one:

  thermal_sys: cpu0-thermal: Failed to read thermal-sensors cells: -2
  thermal_sys: Failed to find thermal zone for tmu id=0
  exynos-tmu 10064000.tmu: Failed to register sensor: -2
  exynos-tmu: probe of 10064000.tmu failed with error -2

Fixes: f1722d7dd8b8 ("ARM: dts: Define default thermal-zones for exynos5422")
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20230209105841.779596-6-krzysztof.kozlowski@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi

index a6961ff24030431706575fbf9699f148c90970d5..e6e7e2ff2a261f067f72bac09a33e72d7c06cbec 100644 (file)
@@ -50,7 +50,7 @@
 
        thermal-zones {
                cpu0_thermal: cpu0-thermal {
-                       thermal-sensors = <&tmu_cpu0 0>;
+                       thermal-sensors = <&tmu_cpu0>;
                        polling-delay-passive = <250>;
                        polling-delay = <0>;
                        trips {
                        };
                };
                cpu1_thermal: cpu1-thermal {
-                       thermal-sensors = <&tmu_cpu1 0>;
+                       thermal-sensors = <&tmu_cpu1>;
                        polling-delay-passive = <250>;
                        polling-delay = <0>;
                        trips {
                        };
                };
                cpu2_thermal: cpu2-thermal {
-                       thermal-sensors = <&tmu_cpu2 0>;
+                       thermal-sensors = <&tmu_cpu2>;
                        polling-delay-passive = <250>;
                        polling-delay = <0>;
                        trips {
                        };
                };
                cpu3_thermal: cpu3-thermal {
-                       thermal-sensors = <&tmu_cpu3 0>;
+                       thermal-sensors = <&tmu_cpu3>;
                        polling-delay-passive = <250>;
                        polling-delay = <0>;
                        trips {
                        };
                };
                gpu_thermal: gpu-thermal {
-                       thermal-sensors = <&tmu_gpu 0>;
+                       thermal-sensors = <&tmu_gpu>;
                        polling-delay-passive = <250>;
                        polling-delay = <0>;
                        trips {