]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
net: tc_act: drop include of module.h from tc_ife.h
authorPaul Gortmaker <paul.gortmaker@windriver.com>
Sun, 21 Apr 2019 03:29:45 +0000 (23:29 -0400)
committerDavid S. Miller <davem@davemloft.net>
Tue, 23 Apr 2019 04:50:53 +0000 (21:50 -0700)
Ideally, header files under include/linux shouldn't be adding
includes of other headers, in anticipation of their consumers,
but just the headers needed for the header itself to pass
parsing with CPP.

The module.h is particularly bad in this sense, as it itself does
include a whole bunch of other headers, due to the complexity of
module support.

Since tc_ife.h is not going into a module struct looking for
specific fields, we can just let it know that module is a struct,
just like about 60 other include/linux headers already do.

Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/tc_act/tc_ife.h

index 86d13b01b39d52cbfcee49e81f8f4cd2fbf0eaf2..c7f24a2da1cad46ade04d5103a8883cebff034e9 100644 (file)
@@ -5,7 +5,8 @@
 #include <net/act_api.h>
 #include <linux/etherdevice.h>
 #include <linux/rtnetlink.h>
-#include <linux/module.h>
+
+struct module;
 
 struct tcf_ife_params {
        u8 eth_dst[ETH_ALEN];