]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
rapidio: Replace 'select' DMAENGINES 'with depends on'
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Tue, 28 Jul 2020 22:19:40 +0000 (01:19 +0300)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 9 Nov 2020 13:46:54 +0000 (14:46 +0100)
BugLink: https://bugs.launchpad.net/bugs/1896828
[ Upstream commit d2b86100245080cfdf1e95e9e07477474c1be2bd ]

Enabling a whole subsystem from a single driver 'select' is frowned
upon and won't be accepted in new drivers, that need to use 'depends on'
instead. Existing selection of DMAENGINES will then cause circular
dependencies. Replace them with a dependency.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: William Breathitt Gray <william.gray@canonical.com>
drivers/rapidio/Kconfig

index 677d1aff61b7f38889bff0caefd3ae8a4578ee05..788e7830771bec84cea33ca549e3b5539ad9b229 100644 (file)
@@ -37,7 +37,7 @@ config RAPIDIO_ENABLE_RX_TX_PORTS
 config RAPIDIO_DMA_ENGINE
        bool "DMA Engine support for RapidIO"
        depends on RAPIDIO
-       select DMADEVICES
+       depends on DMADEVICES
        select DMA_ENGINE
        help
          Say Y here if you want to use DMA Engine frameork for RapidIO data