]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
tty: Update code comment in __proc_set_tty()
authorPeter Hurley <peter@hurleysoftware.com>
Thu, 16 Oct 2014 18:59:50 +0000 (14:59 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 6 Nov 2014 00:26:14 +0000 (16:26 -0800)
The session and foreground process group pid references will be
non-NULL if tiocsctty() is stealing the controlling tty from another
session (ie., arg == 1 in tiocsctty()).

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Reviewed-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/tty_io.c

index 07275d0e30a25d41a79c7a4bd702c5d234819616..9d1e247ee330c4083a4118c580d586383a4547eb 100644 (file)
@@ -516,8 +516,11 @@ static void __proc_set_tty(struct tty_struct *tty)
 {
        unsigned long flags;
 
-       /* We should not have a session or pgrp to put here but.... */
        spin_lock_irqsave(&tty->ctrl_lock, flags);
+       /*
+        * The session and fg pgrp references will be non-NULL if
+        * tiocsctty() is stealing the controlling tty
+        */
        put_pid(tty->session);
        put_pid(tty->pgrp);
        tty->pgrp = get_pid(task_pgrp(current));