]> git.proxmox.com Git - qemu.git/commitdiff
cpus: Use qemu_for_each_cpu() in TCG thread
authorIgor Mammedov <imammedo@redhat.com>
Tue, 23 Apr 2013 08:29:42 +0000 (10:29 +0200)
committerAndreas Färber <afaerber@suse.de>
Wed, 1 May 2013 11:04:18 +0000 (13:04 +0200)
Replaces an open-coded loop and hides unused CPUArchState.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
cpus.c

diff --git a/cpus.c b/cpus.c
index 1d8876157c96b662ea5c31c183c44467d497c714..a2d92c7a881cbcd5e9130a9ad0ac4f3cba1b4b36 100644 (file)
--- a/cpus.c
+++ b/cpus.c
@@ -812,6 +812,12 @@ static void *qemu_dummy_cpu_thread_fn(void *arg)
 
 static void tcg_exec_all(void);
 
+static void tcg_signal_cpu_creation(CPUState *cpu, void *data)
+{
+    cpu->thread_id = qemu_get_thread_id();
+    cpu->created = true;
+}
+
 static void *qemu_tcg_cpu_thread_fn(void *arg)
 {
     CPUState *cpu = arg;
@@ -820,13 +826,8 @@ static void *qemu_tcg_cpu_thread_fn(void *arg)
     qemu_tcg_init_cpu_signals();
     qemu_thread_get_self(cpu->thread);
 
-    /* signal CPU creation */
     qemu_mutex_lock(&qemu_global_mutex);
-    for (env = first_cpu; env != NULL; env = env->next_cpu) {
-        cpu = ENV_GET_CPU(env);
-        cpu->thread_id = qemu_get_thread_id();
-        cpu->created = true;
-    }
+    qemu_for_each_cpu(tcg_signal_cpu_creation, NULL);
     qemu_cond_signal(&qemu_cpu_cond);
 
     /* wait for initial kick-off after machine start */