]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
do_wait: kill the old BUG_ON, use while_each_thread()
authorOleg Nesterov <oleg@redhat.com>
Wed, 17 Jun 2009 23:27:41 +0000 (16:27 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 18 Jun 2009 20:03:53 +0000 (13:03 -0700)
do_wait() does BUG_ON(tsk->signal != current->signal), this looks like a
raher obsolete check.  At least, I don't think do_wait() is the best place
to verify that all threads have the same ->signal.  Remove it.

Also, change the code to use while_each_thread().

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>
Acked-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/exit.c

index 9c6881a0a8b40b71301d74eeeba6aff78327a5a5..dd83c841910121131a443afd3673a52b000917c0 100644 (file)
@@ -1595,9 +1595,7 @@ repeat:
 
                if (wo->wo_flags & __WNOTHREAD)
                        break;
-               tsk = next_thread(tsk);
-               BUG_ON(tsk->signal != current->signal);
-       } while (tsk != current);
+       } while_each_thread(current, tsk);
        read_unlock(&tasklist_lock);
 
 notask: