]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commitdiff
brcmfmac: fix brcmf_sdcard_recv_chain() for host without sg support
authorArend van Spriel <arend@broadcom.com>
Tue, 15 Oct 2013 13:44:57 +0000 (15:44 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 18 Oct 2013 18:06:58 +0000 (14:06 -0400)
If the SDIO host controller does not support scatter-gather the glom
superframe must be transfered from the device and the data for each
packet in the queue must be extracted from it.

Reviewed-by: Franky Lin <frankyl@broadcom.com>
Reviewed-by: Hante Meuleman <meuleman@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c
drivers/net/wireless/brcm80211/brcmfmac/sdio_host.h

index 1103dc1cc9dc2516465ea7f147693653ecc2e3e0..3e10b801eee84bc420867815ced96a3fca3428b4 100644 (file)
@@ -569,8 +569,10 @@ done:
 }
 
 int brcmf_sdcard_recv_chain(struct brcmf_sdio_dev *sdiodev, u32 addr, uint fn,
-                           uint flags, struct sk_buff_head *pktq)
+                           uint flags, struct sk_buff_head *pktq, uint totlen)
 {
+       struct sk_buff *glom_skb;
+       struct sk_buff *skb;
        uint width;
        int err = 0;
 
@@ -582,7 +584,22 @@ int brcmf_sdcard_recv_chain(struct brcmf_sdio_dev *sdiodev, u32 addr, uint fn,
        if (err)
                goto done;
 
-       err = brcmf_sdio_sglist_rw(sdiodev, fn, false, addr, pktq);
+       if (pktq->qlen == 1)
+               err = brcmf_sdio_buffrw(sdiodev, fn, false, addr, pktq->next);
+       else if (!sdiodev->sg_support) {
+               glom_skb = brcmu_pkt_buf_get_skb(totlen);
+               if (!glom_skb)
+                       return -ENOMEM;
+               err = brcmf_sdio_buffrw(sdiodev, fn, false, addr, glom_skb);
+               if (err)
+                       goto done;
+
+               skb_queue_walk(pktq, skb) {
+                       memcpy(skb->data, glom_skb->data, skb->len);
+                       skb_pull(glom_skb, skb->len);
+               }
+       } else
+               err = brcmf_sdio_sglist_rw(sdiodev, fn, false, addr, pktq);
 
 done:
        return err;
index c9277011a1bcaef99cc95ef1f2e36dbced4af024..b02953c4ade721235fbe0e4ed662aaa422ab21f7 100644 (file)
@@ -1392,7 +1392,7 @@ static u8 brcmf_sdbrcm_rxglom(struct brcmf_sdio *bus, u8 rxseq)
                sdio_claim_host(bus->sdiodev->func[1]);
                errcode = brcmf_sdcard_recv_chain(bus->sdiodev,
                                bus->sdiodev->sbwad,
-                               SDIO_FUNC_2, F2SYNC, &bus->glom);
+                               SDIO_FUNC_2, F2SYNC, &bus->glom, dlen);
                sdio_release_host(bus->sdiodev->func[1]);
                bus->sdcnt.f2rxdata++;
 
index 59c456f7eb122b80b787fbad585cf1cdb8f611bc..1b034ea46f932ff4c8aea837b88603861b2e44c0 100644 (file)
@@ -225,7 +225,7 @@ brcmf_sdcard_recv_buf(struct brcmf_sdio_dev *sdiodev, u32 addr, uint fn,
                      uint flags, u8 *buf, uint nbytes);
 extern int
 brcmf_sdcard_recv_chain(struct brcmf_sdio_dev *sdiodev, u32 addr, uint fn,
-                       uint flags, struct sk_buff_head *pktq);
+                       uint flags, struct sk_buff_head *pktq, uint totlen);
 
 /* Flags bits */