]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
ASoC: wm_adsp: Update naming in error handling
authorCharles Keepax <ckeepax@opensource.cirrus.com>
Tue, 18 Aug 2020 16:01:26 +0000 (17:01 +0100)
committerMark Brown <broonie@kernel.org>
Tue, 18 Aug 2020 17:22:17 +0000 (18:22 +0100)
It seems the datasheet has never used the word slave for this error
status bit and has always used the term address error. So update the
driver to match the datasheets and also in the process align a bit
better with avoiding the use of such words where possible.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20200818160126.4852-1-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm_adsp.c

index 410cca57da52ddbbd766d693ff0c6ec4f6143d5f..4ff0c6cfa32de529bcc245495e58682f48da3f9c 100644 (file)
 #define ADSP2_PMEM_ERR_ADDR_XMEM_ERR_ADDR    0x7C
 
 #define ADSP2_REGION_LOCK_ERR_MASK           0x8000
-#define ADSP2_SLAVE_ERR_MASK                 0x4000
+#define ADSP2_ADDR_ERR_MASK                  0x4000
 #define ADSP2_WDT_TIMEOUT_STS_MASK           0x2000
 #define ADSP2_CTRL_ERR_PAUSE_ENA             0x0002
 #define ADSP2_CTRL_ERR_EINT                  0x0001
@@ -4364,9 +4364,9 @@ irqreturn_t wm_adsp2_bus_error(int irq, void *data)
                wm_adsp_fatal_error(dsp);
        }
 
-       if (val & (ADSP2_SLAVE_ERR_MASK | ADSP2_REGION_LOCK_ERR_MASK)) {
-               if (val & ADSP2_SLAVE_ERR_MASK)
-                       adsp_err(dsp, "bus error: slave error\n");
+       if (val & (ADSP2_ADDR_ERR_MASK | ADSP2_REGION_LOCK_ERR_MASK)) {
+               if (val & ADSP2_ADDR_ERR_MASK)
+                       adsp_err(dsp, "bus error: address error\n");
                else
                        adsp_err(dsp, "bus error: region lock error\n");