]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
of/platform: Generalize /reserved-memory handling
authorBjorn Andersson <bjorn.andersson@linaro.org>
Wed, 11 Oct 2017 05:08:53 +0000 (22:08 -0700)
committerAndy Gross <andy.gross@linaro.org>
Sun, 22 Oct 2017 10:06:33 +0000 (05:06 -0500)
By iterating over all /reserved-memory child nodes and match each one to
a list of compatibles that we want to treat specially, we can easily
extend the list of compatibles to handle - without having to resort to
of_platform_populate() that would create unnecessary platform_devices.

Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Andy Gross <andy.gross@linaro.org>
drivers/of/platform.c

index ac15d0e3d27d3b16794f427d72d0b89890909ec2..922b46646bcc94b730bc3142c2a8422c1ca1c037 100644 (file)
@@ -497,6 +497,11 @@ int of_platform_default_populate(struct device_node *root,
 EXPORT_SYMBOL_GPL(of_platform_default_populate);
 
 #ifndef CONFIG_PPC
+static const struct of_device_id reserved_mem_matches[] = {
+       { .compatible = "ramoops" },
+       {}
+};
+
 static int __init of_platform_default_populate_init(void)
 {
        struct device_node *node;
@@ -505,15 +510,12 @@ static int __init of_platform_default_populate_init(void)
                return -ENODEV;
 
        /*
-        * Handle ramoops explicitly, since it is inside /reserved-memory,
-        * which lacks a "compatible" property.
+        * Handle certain compatibles explicitly, since we don't want to create
+        * platform_devices for every node in /reserved-memory with a
+        * "compatible",
         */
-       node = of_find_node_by_path("/reserved-memory");
-       if (node) {
-               node = of_find_compatible_node(node, NULL, "ramoops");
-               if (node)
-                       of_platform_device_create(node, NULL, NULL);
-       }
+       for_each_matching_node(node, reserved_mem_matches)
+               of_platform_device_create(node, NULL, NULL);
 
        /* Populate everything else. */
        of_platform_default_populate(NULL, NULL, NULL);