bgpd: Be careful about displaying vni's as labels.

When a type 2/3 or 5 route is received, verified and the
resulting route generated is pushed into the appropriate vrf
the vni's associated with the route are also passed in.
This is showing up as a Remote label when you dump
the route in bgp:

BGP routing table entry for 0.0.0.0/0^M
Paths: (1 available, best #1, table third)
   Advertised to non peer-group peers:
   10.10.120.22
   42001 42005 42006 42055
     10.10.120.22 from 10.10.120.22 (10.10.255.193)
       Origin IGP, valid, external, bestpath-from-AS 42001, best
       Remote label: 62750
       AddPath ID: RX 0, TX 2
       Last update: Fri Oct 11 12:59:56 2019

The `Remote label: 62750` is the mpls label version of the
vni passed in.  This is meaningless and confusing to the end
user.  Do not display this information.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

diff --git a/bgpd/bgp_route.c b/bgpd/bgp_route.c
index fa64d3dd62a9c2f52741a8240aa6220fc8f7e91d..1305f18fe8c7e346d0424b1c9043867c0859703a 100644 (file)
--- a/bgpd/bgp_route.c
+++ b/bgpd/bgp_route.c
@@ -8967,7 +8967,7 @@ void route_vty_out_detail(struct vty *vty, struct bgp *bgp,
 
                /* Remote Label */
                if (path->extra && bgp_is_valid_label(&path->extra->label[0])
-                   && safi != SAFI_EVPN) {
+                   && (safi != SAFI_EVPN && !is_route_parent_evpn(path))) {
                        mpls_label_t label = label_pton(&path->extra->label[0]);
 
                        if (json_paths)