]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commitdiff
[media] soc-camera: Fix a return value in case of error
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 18 Nov 2016 17:49:15 +0000 (15:49 -0200)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Mon, 30 Jan 2017 16:46:44 +0000 (14:46 -0200)
If 'ov9640_reg_read()' does not return 0, then 'val' is left unmodified.
As it is not initialized either, the return value can be anything.

It is likely that returning the error code was expected here.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/i2c/soc_camera/ov9640.c

index 8c93c57af71cd2c7413b0bdd5564d1f070bf0f66..65085a235128ecd844199b292a549a7d2a8841e2 100644 (file)
@@ -233,7 +233,7 @@ static int ov9640_reg_rmw(struct i2c_client *client, u8 reg, u8 set, u8 unset)
        if (ret) {
                dev_err(&client->dev,
                        "[Read]-Modify-Write of register %02x failed!\n", reg);
-               return val;
+               return ret;
        }
 
        val |= set;