commit: always initialize commit message

When parsing a commit, we will treat all bytes left after parsing
the headers as the commit message. When no bytes are left, we
leave the commit's message uninitialized. While uncommon to have
a commit without message, this is the right behavior as Git
unfortunately allows for empty commit messages.

Given that this scenario is so uncommon, most programs acting on
the commit message will never check if the message is actually
set, which may lead to errors. To work around the error and not
lay the burden of checking for empty commit messages to the
developer, initialize the commit message with an empty string
when no commit message is given.

diff --git a/src/commit.c b/src/commit.c
index 99a80855c49d8fc385b1b602d09d2b1506f2efa5..76e6dcbc95de5bc30e011d5dbe2a4fc1ab443b53 100644 (file)
--- a/src/commit.c
+++ b/src/commit.c
@@ -459,10 +459,11 @@ int git_commit__parse(void *_commit, git_odb_object *odb_obj)
        buffer = buffer_start + header_len + 1;
 
        /* extract commit message */
-       if (buffer <= buffer_end) {
+       if (buffer <= buffer_end)
                commit->raw_message = git__strndup(buffer, buffer_end - buffer);
-               GITERR_CHECK_ALLOC(commit->raw_message);
-       }
+       else
+               commit->raw_message = git__strdup("");
+       GITERR_CHECK_ALLOC(commit->raw_message);
 
        return 0;