]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
net-next:asix:poll in asix_get_phyid in case phy not ready
authorGrant Grundler <grundler@google.com>
Tue, 15 Nov 2011 07:12:40 +0000 (07:12 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 15 Nov 2011 21:26:06 +0000 (16:26 -0500)
Sometimes the phy isn't ready after reset...poll and pray it will be soon.

Signed-off-by: Freddy Xin <freddy@asix.com.tw>
Signed-off-by: Grant Grundler <grundler@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/asix.c

index 873860d46e9ed2dad7d3f8e9e32eebe97ef68c5c..b4675e89e42cd5ffbde0165c33ae307c1fc4c72f 100644 (file)
@@ -652,9 +652,17 @@ static u32 asix_get_phyid(struct usbnet *dev)
 {
        int phy_reg;
        u32 phy_id;
+       int i;
 
-       phy_reg = asix_mdio_read(dev->net, dev->mii.phy_id, MII_PHYSID1);
-       if (phy_reg < 0)
+       /* Poll for the rare case the FW or phy isn't ready yet.  */
+       for (i = 0; i < 100; i++) {
+               phy_reg = asix_mdio_read(dev->net, dev->mii.phy_id, MII_PHYSID1);
+               if (phy_reg != 0 && phy_reg != 0xFFFF)
+                       break;
+               mdelay(1);
+       }
+
+       if (phy_reg <= 0 || phy_reg == 0xFFFF)
                return 0;
 
        phy_id = (phy_reg & 0xffff) << 16;