]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
rtc: brcmstb-waketimer: add missed clk_disable_unprepare
authorChuhong Yuan <hslester96@gmail.com>
Tue, 5 Nov 2019 16:00:43 +0000 (00:00 +0800)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 14 Feb 2020 05:29:37 +0000 (00:29 -0500)
BugLink: https://bugs.launchpad.net/bugs/1861934
commit 94303f8930ed78aea0f189b703c9d79fff9555d7 upstream.

This driver forgets to disable and unprepare clock when remove.
Add a call to clk_disable_unprepare to fix it.

Fixes: c4f07ecee22e ("rtc: brcmstb-waketimer: Add Broadcom STB wake-timer")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20191105160043.20018-1-hslester96@gmail.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/rtc/rtc-brcmstb-waketimer.c

index 6cee61201c30cb4a15eef3fbd72a7df57313e04b..cc201d570cedf7fa3bc1b9cd4d4d0989edce5b58 100644 (file)
@@ -272,6 +272,7 @@ static int brcmstb_waketmr_probe(struct platform_device *pdev)
 
 err_notifier:
        unregister_reboot_notifier(&timer->reboot_notifier);
+       clk_disable_unprepare(timer->clk);
 
 err_clk:
        if (timer->clk)