]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
be2net: fix a crash seen during insmod/rmmod test
authorAjit Khaparde <ajit.khaparde@emulex.com>
Tue, 1 Feb 2011 23:41:13 +0000 (15:41 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 1 Feb 2011 23:41:13 +0000 (15:41 -0800)
While running insmod/rmood in a loop, an unnecessary netif_stop_queue
causes the system to crash. Remove the netif_stop_queue call
and netif_start_queue in the link status update path.

Signed-off-by: Ajit Khaparde <ajit.khaparde@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/benet/be_main.c

index de40d3b7152f5f1454d5e998f54007600ebb860a..9aaf1ef704e9dc005385d38167077df157fe4ef5 100644 (file)
@@ -312,11 +312,9 @@ void be_link_status_update(struct be_adapter *adapter, bool link_up)
        if (adapter->link_up != link_up) {
                adapter->link_speed = -1;
                if (link_up) {
-                       netif_start_queue(netdev);
                        netif_carrier_on(netdev);
                        printk(KERN_INFO "%s: Link up\n", netdev->name);
                } else {
-                       netif_stop_queue(netdev);
                        netif_carrier_off(netdev);
                        printk(KERN_INFO "%s: Link down\n", netdev->name);
                }