]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
watchdog: s3c2410_wdt: Remove unneeded initialization
authorSachin Kamat <sachin.kamat@linaro.org>
Tue, 4 Mar 2014 09:34:34 +0000 (15:04 +0530)
committerWim Van Sebroeck <wim@iguana.be>
Mon, 31 Mar 2014 11:32:34 +0000 (13:32 +0200)
Initializing clk to NULL as a reset/error condition does not
help as NULL is not an invalid condition w.r.t clk. Remove this
initialization altogether as there is no state retention.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/s3c2410_wdt.c

index aba6cd46b45ba047a2d42cb8f48420f411e6cc93..a0f8f771adec6fa74c77968f388e4182d2f3f865 100644 (file)
@@ -607,7 +607,6 @@ static int s3c2410wdt_probe(struct platform_device *pdev)
 
  err_clk:
        clk_disable_unprepare(wdt->clock);
-       wdt->clock = NULL;
 
  err:
        return ret;
@@ -627,7 +626,6 @@ static int s3c2410wdt_remove(struct platform_device *dev)
        s3c2410wdt_cpufreq_deregister(wdt);
 
        clk_disable_unprepare(wdt->clock);
-       wdt->clock = NULL;
 
        return 0;
 }