]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
platform/x86: amd-pmc: Use return code on suspend
authorMario Limonciello <mario.limonciello@amd.com>
Wed, 7 Jul 2021 14:16:47 +0000 (09:16 -0500)
committerHans de Goede <hdegoede@redhat.com>
Wed, 14 Jul 2021 13:39:47 +0000 (15:39 +0200)
Right now the driver will still return success even if the OS_HINT
command failed to send to the SMU. In the rare event of a failure,
the suspend should really be aborted here so that relevant logs
can may be captured.

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Link: https://lore.kernel.org/r/20210707141647.8871-1-mario.limonciello@amd.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/amd-pmc.c

index d2f9a62e116607e10c8ff0f2454674937b40ae6c..680f94c7e075b8f11198e095cb60c83ca3ffde56 100644 (file)
@@ -353,7 +353,7 @@ static int __maybe_unused amd_pmc_suspend(struct device *dev)
        if (rc)
                dev_err(pdev->dev, "suspend failed\n");
 
-       return 0;
+       return rc;
 }
 
 static int __maybe_unused amd_pmc_resume(struct device *dev)