usb: typec: ucsi: acpi: fix a NULL vs IS_ERR() check in probe

The devm_memremap() function never returns NULL.  It returns error
pointers.

Fixes: cdc3d2abf438 ("usb: typec: ucsi: acpi: Map the mailbox with memremap()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

diff --git a/drivers/usb/typec/ucsi/ucsi_acpi.c b/drivers/usb/typec/ucsi/ucsi_acpi.c
index 7455e3aff2be0975f864548aed9aaef5fccc1303..8873c1644a2953d008f52f69f5435cc28d7778eb 100644 (file)
--- a/drivers/usb/typec/ucsi/ucsi_acpi.c
+++ b/drivers/usb/typec/ucsi/ucsi_acpi.c
@@ -133,8 +133,8 @@ static int ucsi_acpi_probe(struct platform_device *pdev)
        }
 
        ua->base = devm_memremap(&pdev->dev, res->start, resource_size(res), MEMREMAP_WB);
-       if (!ua->base)
-               return -ENOMEM;
+       if (IS_ERR(ua->base))
+               return PTR_ERR(ua->base);
 
        ret = guid_parse(UCSI_DSM_UUID, &ua->guid);
        if (ret)