]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
r8169: remove not needed checks in rtl8169_set_eee
authorHeiner Kallweit <hkallweit1@gmail.com>
Thu, 14 May 2020 21:39:34 +0000 (23:39 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 15 May 2020 01:03:01 +0000 (18:03 -0700)
After 9de5d235b60a ("net: phy: fix aneg restart in phy_ethtool_set_eee")
we don't need the check for aneg being enabled any longer, and as
discussed with Russell configuring the EEE advertisement should be
supported even if we're in a half-duplex mode currently.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169_main.c

index b4e49c446bd0527a4e2c38f02a126369a0b58b56..a2e7784171445a0ec67b1be317cc1885815f065b 100644 (file)
@@ -1919,12 +1919,6 @@ static int rtl8169_set_eee(struct net_device *dev, struct ethtool_eee *data)
                goto out;
        }
 
-       if (dev->phydev->autoneg == AUTONEG_DISABLE ||
-           dev->phydev->duplex != DUPLEX_FULL) {
-               ret = -EPROTONOSUPPORT;
-               goto out;
-       }
-
        ret = phy_ethtool_set_eee(tp->phydev, data);
 
        if (!ret)