]> git.proxmox.com Git - mirror_qemu.git/commitdiff
block-backend: drop INT_MAX restriction from blk_check_byte_request()
authorVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Wed, 6 Oct 2021 13:17:18 +0000 (15:17 +0200)
committerEric Blake <eblake@redhat.com>
Fri, 15 Oct 2021 21:00:07 +0000 (16:00 -0500)
blk_check_bytes_request is called from blk_co_do_preadv,
blk_co_do_pwritev_part, blk_co_do_pdiscard and blk_co_copy_range
before (maybe) calling throttle_group_co_io_limits_intercept() (which
has int64_t argument) and then calling corresponding bdrv_co_ function.
bdrv_co_ functions are OK with int64_t bytes as well.

So dropping the check for INT_MAX we just get same restrictions as in
bdrv_ layer: discard and write-zeroes goes through
bdrv_check_qiov_request() and are allowed to be 64bit. Other requests
go through bdrv_check_request32() and still restricted by INT_MAX
boundary.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20211006131718.214235-13-vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
block/block-backend.c

index 59746eda45b0e86ca2991d17ce4add36e9b26edb..39cd99df2b3c1f3e797712276cb89b650b27e231 100644 (file)
@@ -1166,7 +1166,7 @@ static int blk_check_byte_request(BlockBackend *blk, int64_t offset,
 {
     int64_t len;
 
-    if (bytes < 0 || bytes > INT_MAX) {
+    if (bytes < 0) {
         return -EIO;
     }