]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
hwrng: stm32 - fix unbalanced pm_runtime_enable
authorLionel Debieve <lionel.debieve@st.com>
Mon, 1 Apr 2019 10:30:45 +0000 (12:30 +0200)
committerMarcelo Henrique Cerri <marcelo.cerri@canonical.com>
Fri, 17 Jan 2020 17:21:49 +0000 (14:21 -0300)
BugLink: https://bugs.launchpad.net/bugs/1855787
commit af0d4442dd6813de6e77309063beb064fa8e89ae upstream.

No remove function implemented yet in the driver.
Without remove function, the pm_runtime implementation
complains when removing and probing again the driver.

Signed-off-by: Lionel Debieve <lionel.debieve@st.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/char/hw_random/stm32-rng.c

index 83c695938a2d7a08d65a846c0d23b3a4cb5cbd13..f53d47e3355d520eec5fb219472093ba038970cb 100644 (file)
@@ -166,6 +166,13 @@ static int stm32_rng_probe(struct platform_device *ofdev)
        return devm_hwrng_register(dev, &priv->rng);
 }
 
+static int stm32_rng_remove(struct platform_device *ofdev)
+{
+       pm_runtime_disable(&ofdev->dev);
+
+       return 0;
+}
+
 #ifdef CONFIG_PM
 static int stm32_rng_runtime_suspend(struct device *dev)
 {
@@ -202,6 +209,7 @@ static struct platform_driver stm32_rng_driver = {
                .of_match_table = stm32_rng_match,
        },
        .probe = stm32_rng_probe,
+       .remove = stm32_rng_remove,
 };
 
 module_platform_driver(stm32_rng_driver);