ui: make Sync/VerifyView and Edit usable without datastore

we want to use this panel again for a 'global' overview, without
any datastore preselected, so we have to handle that, and
adding a datastore selector in the editwindow

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>

diff --git a/www/config/SyncView.js b/www/config/SyncView.js
index 20fc5e868e16cddc29df1565fe215d22736c6340..24990ff0df5036ea42b4ad08e7b9fea62896f22f 100644 (file)
--- a/www/config/SyncView.js
+++ b/www/config/SyncView.js
@@ -162,9 +162,11 @@ Ext.define('PBS.config.SyncJobView', {
        reload: function() { this.getView().getStore().rstore.load(); },
 
        init: function(view) {
-           view.getStore().rstore.getProxy().setExtraParams({
-               store: view.datastore,
-           });
+           let params = {};
+           if (view.datastore !== undefined) {
+               params.store = view.datastore;
+           }
+           view.getStore().rstore.getProxy().setExtraParams(params);
            Proxmox.Utils.monStoreErrors(view, view.getStore().rstore);
        },
     },

diff --git a/www/config/VerifyView.js b/www/config/VerifyView.js
index da8e98899ef336f5866011a19a94092c11e2474d..8a0ed6d4c2b201ad23efe5453e433ba062ef2d61 100644 (file)
--- a/www/config/VerifyView.js
+++ b/www/config/VerifyView.js
@@ -157,9 +157,11 @@ Ext.define('PBS.config.VerifyJobView', {
        reload: function() { this.getView().getStore().rstore.load(); },
 
        init: function(view) {
-           view.getStore().rstore.getProxy().setExtraParams({
-               store: view.datastore,
-           });
+           let params = {};
+           if (view.datastore !== undefined) {
+               params.store = view.datastore;
+           }
+           view.getStore().rstore.getProxy().setExtraParams(params);
            Proxmox.Utils.monStoreErrors(view, view.getStore().rstore);
        },
     },

diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js
index 573a4af6cceeb48676785056bcb2f5ea3dc9802f..982cec934774c44479b14f8fa4d642722157efd6 100644 (file)
--- a/www/window/SyncJobEdit.js
+++ b/www/window/SyncJobEdit.js
@@ -113,6 +113,7 @@ Ext.define('PBS.window.SyncJobEdit', {
        me.autoLoad = !!id;
        me.scheduleValue = id ? null : 'hourly';
        me.authid = id ? null : Proxmox.UserName;
+       me.editDatastore = me.datastore === undefined && me.isCreate;
        return { };
     },
 
@@ -128,14 +129,18 @@ Ext.define('PBS.window.SyncJobEdit', {
        },
        column1: [
            {
-               xtype: 'displayfield',
-               name: 'store',
+               xtype: 'pmxDisplayEditField',
                fieldLabel: gettext('Local Datastore'),
-               allowBlank: false,
+               name: 'store',
                submitValue: true,
                cbind: {
+                   editable: '{editDatastore}',
                    value: '{datastore}',
                },
+               editConfig: {
+                   xtype: 'pbsDataStoreSelector',
+                   allowBlank: false,
+               },
            },
            {
                fieldLabel: gettext('Local Owner'),

diff --git a/www/window/VerifyJobEdit.js b/www/window/VerifyJobEdit.js
index 48a181b668edbb3c40b3842385bf4059be8be425..6153c8e535288957dd233b7c9c244d37b6513816 100644 (file)
--- a/www/window/VerifyJobEdit.js
+++ b/www/window/VerifyJobEdit.js
@@ -24,6 +24,7 @@ Ext.define('PBS.window.VerifyJobEdit', {
        me.url = id ? `${baseurl}/${id}` : baseurl;
        me.method = id ? 'PUT' : 'POST';
        me.autoLoad = !!id;
+       me.editDatastore = me.datastore === undefined && me.isCreate;
        return { };
     },
 
@@ -45,14 +46,18 @@ Ext.define('PBS.window.VerifyJobEdit', {
        },
        column1: [
            {
-               xtype: 'displayfield',
+               xtype: 'pmxDisplayEditField',
+               fieldLabel: gettext('Local Datastore'),
                name: 'store',
-               fieldLabel: gettext('Datastore'),
-               allowBlank: false,
                submitValue: true,
                cbind: {
+                   editable: '{editDatastore}',
                    value: '{datastore}',
                },
+               editConfig: {
+                   xtype: 'pbsDataStoreSelector',
+                   allowBlank: false,
+               },
            },
            {
                xtype: 'pbsCalendarEvent',