]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commitdiff
[media] ov2659: get rid of unused values
authorMauro Carvalho Chehab <mchehab@osg.samsung.com>
Tue, 11 Aug 2015 15:18:32 +0000 (12:18 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Sun, 16 Aug 2015 15:55:50 +0000 (12:55 -0300)
Why to store the chosed values for prediv, postdiv and mult if
those won't be used?

drivers/media/i2c/ov2659.c: In function 'ov2659_pll_calc_params':
drivers/media/i2c/ov2659.c:912:35: warning: variable 's_mult' set but not used [-Wunused-but-set-variable]
  u32 s_prediv = 1, s_postdiv = 1, s_mult = 1;
                                   ^
drivers/media/i2c/ov2659.c:912:20: warning: variable 's_postdiv' set but not used [-Wunused-but-set-variable]
  u32 s_prediv = 1, s_postdiv = 1, s_mult = 1;
                    ^
drivers/media/i2c/ov2659.c:912:6: warning: variable 's_prediv' set but not used [-Wunused-but-set-variable]
  u32 s_prediv = 1, s_postdiv = 1, s_mult = 1;
      ^

This is likely some leftover from some past change.

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/i2c/ov2659.c

index 6edffc7b74e3626fa95e1ff400424d03039af238..49109f4f5bb4a14ec471b4915606439a57f3495e 100644 (file)
@@ -909,7 +909,6 @@ static void ov2659_pll_calc_params(struct ov2659 *ov2659)
        u8 ctrl1_reg = 0, ctrl2_reg = 0, ctrl3_reg = 0;
        struct i2c_client *client = ov2659->client;
        unsigned int desired = pdata->link_frequency;
-       u32 s_prediv = 1, s_postdiv = 1, s_mult = 1;
        u32 prediv, postdiv, mult;
        u32 bestdelta = -1;
        u32 delta, actual;
@@ -929,9 +928,6 @@ static void ov2659_pll_calc_params(struct ov2659 *ov2659)
 
                                if ((delta < bestdelta) || (bestdelta == -1)) {
                                        bestdelta = delta;
-                                       s_mult    = mult;
-                                       s_prediv  = prediv;
-                                       s_postdiv = postdiv;
                                        ctrl1_reg = ctrl1[i].reg;
                                        ctrl2_reg = mult;
                                        ctrl3_reg = ctrl3[j].reg;