]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
spi: mxic: add missing braces
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 10 Aug 2021 14:24:05 +0000 (22:24 +0800)
committerMark Brown <broonie@kernel.org>
Thu, 12 Aug 2021 11:19:19 +0000 (12:19 +0100)
Fix the following waring:

drivers/spi/spi-mxic.c: In function ‘mxic_spi_mem_exec_op’:
drivers/spi/spi-mxic.c:401:3: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
   if (op->data.dir == SPI_MEM_DATA_IN)
   ^~
drivers/spi/spi-mxic.c:403:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
    if (op->data.dtr)
    ^~

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Zhengxun Li <zhengxunli@mxic.com.tw>
Link: https://lore.kernel.org/r/20210810142405.2221540-1-yangyingliang@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-mxic.c

index 32e757a04f1469749af5a208a2f1f0da54cdb5a7..45889947afed8aa97799e10b1a66d7cf45606f86 100644 (file)
@@ -398,10 +398,11 @@ static int mxic_spi_mem_exec_op(struct spi_mem *mem,
        if (op->data.nbytes) {
                ss_ctrl |= OP_DATA_BUSW(fls(op->data.buswidth) - 1) |
                           (op->data.dtr ? OP_DATA_DDR : 0);
-               if (op->data.dir == SPI_MEM_DATA_IN)
+               if (op->data.dir == SPI_MEM_DATA_IN) {
                        ss_ctrl |= OP_READ;
                        if (op->data.dtr)
                                ss_ctrl |= OP_DQS_EN;
+               }
        }
 
        writel(ss_ctrl, mxic->regs + SS_CTRL(mem->spi->chip_select));