]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
staging: nvec: Switch from strlcpy to strscpy
authorKumar Kartikeya Dwivedi <memxor@gmail.com>
Sun, 31 Jan 2021 17:28:26 +0000 (22:58 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 4 Feb 2021 16:16:06 +0000 (17:16 +0100)
strlcpy is marked as deprecated in Documentation/process/deprecated.rst,
and there is no functional difference when the caller expects truncation
(when not checking the return value). strscpy is relatively better as it
also avoids scanning the whole source string.

This silences the related checkpatch warnings from:
5dbdb2d87c29 ("checkpatch: prefer strscpy to strlcpy")

Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Link: https://lore.kernel.org/r/20210131172838.146706-6-memxor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/nvec/nvec_ps2.c

index 45db29262a9c4173bae944e4be9601c68bcfdcf3..157009015c3b459e8f0a9ce6360f26b4c0b7880c 100644 (file)
@@ -112,8 +112,8 @@ static int nvec_mouse_probe(struct platform_device *pdev)
        ser_dev->start = ps2_startstreaming;
        ser_dev->stop = ps2_stopstreaming;
 
-       strlcpy(ser_dev->name, "nvec mouse", sizeof(ser_dev->name));
-       strlcpy(ser_dev->phys, "nvec", sizeof(ser_dev->phys));
+       strscpy(ser_dev->name, "nvec mouse", sizeof(ser_dev->name));
+       strscpy(ser_dev->phys, "nvec", sizeof(ser_dev->phys));
 
        ps2_dev.ser_dev = ser_dev;
        ps2_dev.notifier.notifier_call = nvec_ps2_notifier;