]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
dmaengine: xilinx_dma: fix incompatible param warning in _child_probe()
authorShravya Kumbham <shravya.kumbham@xilinx.com>
Wed, 23 Dec 2020 11:21:01 +0000 (16:51 +0530)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 19 Feb 2021 15:44:25 +0000 (16:44 +0100)
BugLink: https://bugs.launchpad.net/bugs/1913487
commit faeb0731be0a31e2246b21a85fa7dabbd750101d upstream.

In xilinx_dma_child_probe function, the nr_channels variable is
passed to of_property_read_u32() which expects an u32 return value
pointer. Modify the nr_channels variable type from int to u32 to
fix the incompatible parameter coverity warning.

Addresses-Coverity: Event incompatible_param.
Fixes: 1a9e7a03c761 ("dmaengine: vdma: Add support for mulit-channel dma mode")
Signed-off-by: Shravya Kumbham <shravya.kumbham@xilinx.com>
Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Link: https://lore.kernel.org/r/1608722462-29519-3-git-send-email-radhey.shyam.pandey@xilinx.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: William Breathitt Gray <william.gray@canonical.com>
drivers/dma/xilinx/xilinx_dma.c

index 73cb2362322f4f014aaf6d545ff0df161ccf6384..e9e5c4ede9fa7a12c3d8fe4189957c837b538ba5 100644 (file)
@@ -2543,7 +2543,8 @@ static int xilinx_dma_chan_probe(struct xilinx_dma_device *xdev,
 static int xilinx_dma_child_probe(struct xilinx_dma_device *xdev,
                                    struct device_node *node)
 {
-       int ret, i, nr_channels = 1;
+       int ret, i;
+       u32 nr_channels = 1;
 
        ret = of_property_read_u32(node, "dma-channels", &nr_channels);
        if ((ret < 0) && xdev->mcdma)