]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
net: lan966x: fix kernel oops on ioctl when I/F is down
authorMichael Walle <michael@walle.cc>
Mon, 28 Mar 2022 22:03:50 +0000 (00:03 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 29 Mar 2022 08:47:24 +0000 (10:47 +0200)
ioctls handled by phy_mii_ioctl() will cause a kernel oops when the
interface is down. Fix it by making sure there is a PHY attached.

Fixes: 735fec995b21 ("net: lan966x: Implement SIOCSHWTSTAMP and SIOCGHWTSTAMP")
Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20220328220350.3118969-1-michael@walle.cc
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/microchip/lan966x/lan966x_main.c

index e1bcb28039dc751bce2ea53f155d886ada2c4a41..1f8c67f0261bf8583ef2bd3da425162188034de5 100644 (file)
@@ -408,6 +408,9 @@ static int lan966x_port_ioctl(struct net_device *dev, struct ifreq *ifr,
                }
        }
 
+       if (!dev->phydev)
+               return -ENODEV;
+
        return phy_mii_ioctl(dev->phydev, ifr, cmd);
 }