]> git.proxmox.com Git - mirror_qemu.git/commitdiff
migration: savevm: fix error code with migration blockers
authorCole Robinson <crobinso@redhat.com>
Tue, 9 Apr 2019 23:19:57 +0000 (19:19 -0400)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Tue, 14 May 2019 16:33:35 +0000 (17:33 +0100)
The only caller that checks the error code is looking for != 0,
so returning false is incorrect.

Fixes: 5aaac467938 "migration: savevm: consult migration blockers"
Signed-off-by: Cole Robinson <crobinso@redhat.com>
Message-Id: <b991a4d0e6c4253bc08b2794c6084be55fc72e1d.1554851834.git.crobinso@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
migration/savevm.c

index 587fec8ce28881db0420aaca8df6ef491f9028ad..81a9a2ef30b07eea03eaac1593fbfd404bb773f9 100644 (file)
@@ -2542,7 +2542,7 @@ int save_snapshot(const char *name, Error **errp)
     AioContext *aio_context;
 
     if (migration_is_blocked(errp)) {
-        return false;
+        return ret;
     }
 
     if (!replay_can_snapshot()) {