ip: validate vlan value for vlan info

The VLAN tag must be 0..4095 to be valid.
Better to trap it here.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

diff --git a/ip/iplink.c b/ip/iplink.c
index e83f1477e7bc3a783692702a7618c32425126454..1e685cc23805060a688152fa2f137cd401935854 100644 (file)
--- a/ip/iplink.c
+++ b/ip/iplink.c
@@ -276,11 +276,13 @@ static void iplink_parse_vf_vlan_info(int vf, int *argcp, char ***argvp,
 {
        int argc = *argcp;
        char **argv = *argvp;
+       unsigned int vci;
 
        NEXT_ARG();
-       if (get_unsigned(&ivvip->vlan, *argv, 0))
+       if (get_unsigned(&vci, *argv, 0) || vci > 4095)
                invarg("Invalid \"vlan\" value\n", *argv);
 
+       ivvip->vlan = vci;
        ivvip->vf = vf;
        ivvip->qos = 0;
        ivvip->vlan_proto = htons(ETH_P_8021Q);