]> git.proxmox.com Git - qemu.git/commitdiff
pci: don't use bus number in migration, stub out
authorMichael S. Tsirkin <mst@redhat.com>
Tue, 14 Dec 2010 12:24:53 +0000 (14:24 +0200)
committerMichael S. Tsirkin <mst@redhat.com>
Sun, 19 Dec 2010 12:06:17 +0000 (14:06 +0200)
Using bus numbers in migration is clearly wrong as
they are guest assigned. Not really sure what the
right thing to do is, for now stick 0 in there so things
keep working for non-nested setups, add a TODO.

We also probably have to mark nested bridges as non-migrateable
until this is fixed?

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Alex Williamson <alex.williamson@redhat.com>
hw/pci.c

index ef00d20d5f665aec54bddbe51bcaf52131e74036..0cb411720d85835251186bcdb5c200515dd6e6e4 100644 (file)
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -2014,7 +2014,10 @@ static char *pcibus_get_dev_path(DeviceState *dev)
     char path[16];
 
     snprintf(path, sizeof(path), "%04x:%02x:%02x.%x",
-             pci_find_domain(d->bus), d->config[PCI_SECONDARY_BUS],
+             pci_find_domain(d->bus),
+             0 /* TODO: need a persistent path for nested buses.
+                * Note: pci_bus_num(d->bus) is not right as it's guest
+                * assigned. */,
              PCI_SLOT(d->devfn), PCI_FUNC(d->devfn));
 
     return strdup(path);