]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
nvme-tcp: fix kconfig dependency warning when !CRYPTO
authorNecip Fazil Yildiran <fazilyildiran@gmail.com>
Mon, 14 Sep 2020 15:01:21 +0000 (18:01 +0300)
committerChristoph Hellwig <hch@lst.de>
Tue, 15 Sep 2020 05:58:49 +0000 (07:58 +0200)
When NVME_TCP is enabled and CRYPTO is disabled, it results in the
following Kbuild warning:

WARNING: unmet direct dependencies detected for CRYPTO_CRC32C
  Depends on [n]: CRYPTO [=n]
  Selected by [y]:
  - NVME_TCP [=y] && INET [=y] && BLK_DEV_NVME [=y]

The reason is that NVME_TCP selects CRYPTO_CRC32C without depending on or
selecting CRYPTO while CRYPTO_CRC32C is subordinate to CRYPTO.

Honor the kconfig menu hierarchy to remove kconfig dependency warnings.

Fixes: 79fd751d61aa ("nvme: tcp: selects CRYPTO_CRC32C for nvme-tcp")
Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/Kconfig

index 3ed9786b88d8edf2859967ba2fb7018ee67ba41d..a44d49d63968a45a4c29f89ac9c7dadcb8890961 100644 (file)
@@ -73,6 +73,7 @@ config NVME_TCP
        depends on INET
        depends on BLK_DEV_NVME
        select NVME_FABRICS
+       select CRYPTO
        select CRYPTO_CRC32C
        help
          This provides support for the NVMe over Fabrics protocol using