]> git.proxmox.com Git - mirror_ovs.git/commitdiff
dpif-netdev: Update comment about flow installation race.
authorIlya Maximets <i.maximets@samsung.com>
Wed, 17 Apr 2019 08:43:56 +0000 (11:43 +0300)
committerIan Stokes <ian.stokes@intel.com>
Thu, 18 Apr 2019 07:51:46 +0000 (08:51 +0100)
Userspace datapath uses per-PMD flow tables/classifiers for a long
time. However, it was decided to keep this race window to not block
revalidators. Comment should be updated to reflect the current state.

Fixes: 1c1e46ed8457 ("dpif-netdev: Add per-pmd flow-table/classifier.")
Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
Reviewed-by: Greg Rose <gvrose8192@gmail.com>
Signed-off-by: Ian Stokes <ian.stokes@intel.com>
lib/dpif-netdev.c

index 35cd0071294fe03027320c65f06a75456ea8851d..c20f875ee097621d274cb7fa99422c18f7f830dc 100644 (file)
@@ -6549,8 +6549,7 @@ handle_packet_upcall(struct dp_netdev_pmd_thread *pmd,
          * could have already been installed since we last did the flow
          * lookup before upcall.  This could be solved by moving the
          * mutex lock outside the loop, but that's an awful long time
-         * to be locking everyone out of making flow installs.  If we
-         * move to a per-core classifier, it would be reasonable. */
+         * to be locking revalidators out of making flow modifications. */
         ovs_mutex_lock(&pmd->flow_mutex);
         netdev_flow = dp_netdev_pmd_lookup_flow(pmd, key, NULL);
         if (OVS_LIKELY(!netdev_flow)) {