]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
drivers: gpio: msm: Fix the error condition for reading ngpio
authorRohit Vaswani <rvaswani@codeaurora.org>
Thu, 18 Jul 2013 20:07:14 +0000 (13:07 -0700)
committerLinus Walleij <linus.walleij@linaro.org>
Sat, 20 Jul 2013 21:33:33 +0000 (23:33 +0200)
of_property_read_u32 return 0 on success. The check was using a ! to
return error. Fix the if condition.

Signed-off-by: Rohit Vaswani <rvaswani@codeaurora.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Pankaj Jangra <jangra.pankaj9@gmail.com>
Cc: "Bird, Tim" <Tim.Bird@sonymobile.com>
Signed-off-by: David Brown <davidb@codeaurora.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-msm-v2.c

index f4491a497cc8760ef59484ac2c6c264573b3b8a9..c2fa77086eb58cf9de7f2c2a453c900a9771f0b5 100644 (file)
@@ -378,7 +378,7 @@ static int msm_gpio_probe(struct platform_device *pdev)
        int ret, ngpio;
        struct resource *res;
 
-       if (!of_property_read_u32(pdev->dev.of_node, "ngpio", &ngpio)) {
+       if (of_property_read_u32(pdev->dev.of_node, "ngpio", &ngpio)) {
                dev_err(&pdev->dev, "%s: ngpio property missing\n", __func__);
                return -EINVAL;
        }