]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
pwm: pxa: Remove clk_enabled field from struct pxa_pwm_chip
authorAxel Lin <axel.lin@ingics.com>
Sun, 31 Mar 2013 15:04:31 +0000 (23:04 +0800)
committerThierry Reding <thierry.reding@avionic-design.de>
Tue, 2 Apr 2013 09:31:37 +0000 (11:31 +0200)
clk_enable/clk_disable maintain an enable_count, clk_prepare and clk_unprepare
also maintain a prepare_count. These APIs will do prepare/enable when the first
user calling these APIs, and do disable/unprepare when the corresponding counter
reach 0. Thus We don't need to maintain a clk_enabled counter here.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Eric Miao <eric.y.miao@gmail.com>
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
drivers/pwm/pwm-pxa.c

index 20370e61de5a2701df605fe2219cbafa6822512e..b78988255aeeb3538105515a684837bdba4f9b32 100644 (file)
@@ -48,7 +48,6 @@ struct pxa_pwm_chip {
        struct device   *dev;
 
        struct clk      *clk;
-       int             clk_enabled;
        void __iomem    *mmio_base;
 };
 
@@ -108,24 +107,15 @@ static int pxa_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
 static int pxa_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
 {
        struct pxa_pwm_chip *pc = to_pxa_pwm_chip(chip);
-       int rc = 0;
 
-       if (!pc->clk_enabled) {
-               rc = clk_prepare_enable(pc->clk);
-               if (!rc)
-                       pc->clk_enabled++;
-       }
-       return rc;
+       return clk_prepare_enable(pc->clk);
 }
 
 static void pxa_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
 {
        struct pxa_pwm_chip *pc = to_pxa_pwm_chip(chip);
 
-       if (pc->clk_enabled) {
-               clk_disable_unprepare(pc->clk);
-               pc->clk_enabled--;
-       }
+       clk_disable_unprepare(pc->clk);
 }
 
 static struct pwm_ops pxa_pwm_ops = {
@@ -152,8 +142,6 @@ static int pwm_probe(struct platform_device *pdev)
        if (IS_ERR(pwm->clk))
                return PTR_ERR(pwm->clk);
 
-       pwm->clk_enabled = 0;
-
        pwm->chip.dev = &pdev->dev;
        pwm->chip.ops = &pxa_pwm_ops;
        pwm->chip.base = -1;