]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commitdiff
selftests/x86: Add an iopl test
authorAndy Lutomirski <luto@kernel.org>
Wed, 16 Mar 2016 21:14:20 +0000 (14:14 -0700)
committerIngo Molnar <mingo@kernel.org>
Thu, 17 Mar 2016 08:49:26 +0000 (09:49 +0100)
This exercises two cases that are known to be buggy on Xen PV right
now.

Signed-off-by: Andy Lutomirski <luto@kernel.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: David Vrabel <david.vrabel@citrix.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Jan Beulich <JBeulich@suse.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/61afe904c95c92abb29cd075b51e10e7feb0f774.1458162709.git.luto@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
tools/testing/selftests/x86/Makefile
tools/testing/selftests/x86/iopl.c [new file with mode: 0644]

index d5ce7d7aae3e41f22d276d39aa365a9e5faa9910..b47ebd1706907e2cd852b3c4c30a82e01ee8d654 100644 (file)
@@ -5,7 +5,7 @@ include ../lib.mk
 .PHONY: all all_32 all_64 warn_32bit_failure clean
 
 TARGETS_C_BOTHBITS := single_step_syscall sysret_ss_attrs syscall_nt ptrace_syscall \
-                       check_initial_reg_state sigreturn ldt_gdt
+                       check_initial_reg_state sigreturn ldt_gdt iopl
 TARGETS_C_32BIT_ONLY := entry_from_vm86 syscall_arg_fault test_syscall_vdso unwind_vdso \
                        test_FCMOV test_FCOMI test_FISTTP \
                        vdso_restorer
diff --git a/tools/testing/selftests/x86/iopl.c b/tools/testing/selftests/x86/iopl.c
new file mode 100644 (file)
index 0000000..c496ca9
--- /dev/null
@@ -0,0 +1,135 @@
+/*
+ * iopl.c - Test case for a Linux on Xen 64-bit bug
+ * Copyright (c) 2015 Andrew Lutomirski
+ */
+
+#define _GNU_SOURCE
+#include <err.h>
+#include <stdio.h>
+#include <stdint.h>
+#include <signal.h>
+#include <setjmp.h>
+#include <stdlib.h>
+#include <string.h>
+#include <errno.h>
+#include <unistd.h>
+#include <sys/types.h>
+#include <sys/wait.h>
+#include <stdbool.h>
+#include <sched.h>
+#include <sys/io.h>
+
+static int nerrs = 0;
+
+static void sethandler(int sig, void (*handler)(int, siginfo_t *, void *),
+                      int flags)
+{
+       struct sigaction sa;
+       memset(&sa, 0, sizeof(sa));
+       sa.sa_sigaction = handler;
+       sa.sa_flags = SA_SIGINFO | flags;
+       sigemptyset(&sa.sa_mask);
+       if (sigaction(sig, &sa, 0))
+               err(1, "sigaction");
+
+}
+
+static jmp_buf jmpbuf;
+
+static void sigsegv(int sig, siginfo_t *si, void *ctx_void)
+{
+       siglongjmp(jmpbuf, 1);
+}
+
+int main(void)
+{
+       cpu_set_t cpuset;
+       CPU_ZERO(&cpuset);
+       CPU_SET(0, &cpuset);
+       if (sched_setaffinity(0, sizeof(cpuset), &cpuset) != 0)
+               err(1, "sched_setaffinity to CPU 0");
+
+       /* Probe for iopl support.  Note that iopl(0) works even as nonroot. */
+       if (iopl(3) != 0) {
+               printf("[OK]\tiopl(3) failed (%d) -- try running as root\n",
+                      errno);
+               return 0;
+       }
+
+       /* Restore our original state prior to starting the test. */
+       if (iopl(0) != 0)
+               err(1, "iopl(0)");
+
+       pid_t child = fork();
+       if (child == -1)
+               err(1, "fork");
+
+       if (child == 0) {
+               printf("\tchild: set IOPL to 3\n");
+               if (iopl(3) != 0)
+                       err(1, "iopl");
+
+               printf("[RUN]\tchild: write to 0x80\n");
+               asm volatile ("outb %%al, $0x80" : : "a" (0));
+
+               return 0;
+       } else {
+               int status;
+               if (waitpid(child, &status, 0) != child ||
+                   !WIFEXITED(status)) {
+                       printf("[FAIL]\tChild died\n");
+                       nerrs++;
+               } else if (WEXITSTATUS(status) != 0) {
+                       printf("[FAIL]\tChild failed\n");
+                       nerrs++;
+               } else {
+                       printf("[OK]\tChild succeeded\n");
+               }
+       }
+
+       printf("[RUN]\tparent: write to 0x80 (should fail)\n");
+
+       sethandler(SIGSEGV, sigsegv, 0);
+       if (sigsetjmp(jmpbuf, 1) != 0) {
+               printf("[OK]\twrite was denied\n");
+       } else {
+               asm volatile ("outb %%al, $0x80" : : "a" (0));
+               printf("[FAIL]\twrite was allowed\n");
+               nerrs++;
+       }
+
+       /* Test the capability checks. */
+       printf("\tiopl(3)\n");
+       if (iopl(3) != 0)
+               err(1, "iopl(3)");
+
+       printf("\tDrop privileges\n");
+       if (setresuid(1, 1, 1) != 0) {
+               printf("[WARN]\tDropping privileges failed\n");
+               goto done;
+       }
+
+       printf("[RUN]\tiopl(3) unprivileged but with IOPL==3\n");
+       if (iopl(3) != 0) {
+               printf("[FAIL]\tiopl(3) should work if iopl is already 3 even if unprivileged\n");
+               nerrs++;
+       }
+
+       printf("[RUN]\tiopl(0) unprivileged\n");
+       if (iopl(0) != 0) {
+               printf("[FAIL]\tiopl(0) should work if iopl is already 3 even if unprivileged\n");
+               nerrs++;
+       }
+
+       printf("[RUN]\tiopl(3) unprivileged\n");
+       if (iopl(3) == 0) {
+               printf("[FAIL]\tiopl(3) should fail if when unprivileged if iopl==0\n");
+               nerrs++;
+       } else {
+               printf("[OK]\tFailed as expected\n");
+       }
+
+done:
+       return nerrs ? 1 : 0;
+}
+