]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
rtlwifi: rtl8192ee: remove redundant for-loop
authorColin Ian King <colin.king@canonical.com>
Fri, 15 May 2020 10:22:26 +0000 (11:22 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 18 May 2020 12:19:17 +0000 (15:19 +0300)
The for-loop seems to be redundant, the assignments for indexes
0..2 are being over-written by the last index 3 in the loop. Remove
the loop and use index 3 instead.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200515102226.29819-1-colin.king@canonical.com
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c

index 6dba576aa81ef2dc5220bf93666e9e6e20e29a27..bb291b951f4d7b18ddb37feed08a67a44ddd498f 100644 (file)
@@ -2866,14 +2866,12 @@ void rtl92ee_phy_iq_calibrate(struct ieee80211_hw *hw, bool b_recovery)
                }
        }
 
-       for (i = 0; i < 4; i++) {
-               reg_e94 = result[i][0];
-               reg_e9c = result[i][1];
-               reg_ea4 = result[i][2];
-               reg_eb4 = result[i][4];
-               reg_ebc = result[i][5];
-               reg_ec4 = result[i][6];
-       }
+       reg_e94 = result[3][0];
+       reg_e9c = result[3][1];
+       reg_ea4 = result[3][2];
+       reg_eb4 = result[3][4];
+       reg_ebc = result[3][5];
+       reg_ec4 = result[3][6];
 
        if (final_candidate != 0xff) {
                reg_e94 = result[final_candidate][0];