]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
drivers/misc: ti-st: remove redundant assignment to variables i and flags
authorColin Ian King <colin.king@canonical.com>
Mon, 13 Jan 2020 12:31:49 +0000 (12:31 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jan 2020 14:16:51 +0000 (15:16 +0100)
The variables i and flags are being initialized with values that are
never read.  The initializations are redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20200113123149.187555-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/ti-st/st_core.c

index 2ae9948a91e16c7a0b5cfcaf62e7c20844740855..14136d2cc8f93ee02defb1762357d8b3ffb65de6 100644 (file)
@@ -736,8 +736,8 @@ static int st_tty_open(struct tty_struct *tty)
 
 static void st_tty_close(struct tty_struct *tty)
 {
-       unsigned char i = ST_MAX_CHANNELS;
-       unsigned long flags = 0;
+       unsigned char i;
+       unsigned long flags;
        struct  st_data_s *st_gdata = tty->disc_data;
 
        pr_info("%s ", __func__);