]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
drivers/rtc/rtc-pcf8563.c: simplify return from function
authorRobert Kmiec <robert.r.kmiec@gmail.com>
Thu, 16 Apr 2015 19:45:01 +0000 (12:45 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 17 Apr 2015 13:03:59 +0000 (09:03 -0400)
This commit does not change any logic here.  It just makes the code easier
to read.

This is how it looked like:
If err != 0 return err;
else return 0;

Signed-off-by: Robert Kmiec <robert.r.kmiec@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/rtc/rtc-pcf8563.c

index 96fb32e7d6f8af04c6a78ecb2e65c35e48b89c48..0ba7e59929beab93b53c2a0d35a9c49b4cf562c5 100644 (file)
@@ -246,7 +246,6 @@ static int pcf8563_get_datetime(struct i2c_client *client, struct rtc_time *tm)
 static int pcf8563_set_datetime(struct i2c_client *client, struct rtc_time *tm)
 {
        struct pcf8563 *pcf8563 = i2c_get_clientdata(client);
-       int err;
        unsigned char buf[9];
 
        dev_dbg(&client->dev, "%s: secs=%d, mins=%d, hours=%d, "
@@ -272,12 +271,8 @@ static int pcf8563_set_datetime(struct i2c_client *client, struct rtc_time *tm)
 
        buf[PCF8563_REG_DW] = tm->tm_wday & 0x07;
 
-       err = pcf8563_write_block_data(client, PCF8563_REG_SC,
+       return pcf8563_write_block_data(client, PCF8563_REG_SC,
                                9 - PCF8563_REG_SC, buf + PCF8563_REG_SC);
-       if (err)
-               return err;
-
-       return 0;
 }
 
 #ifdef CONFIG_RTC_INTF_DEV