]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
orangefs: use sparse annotations for holding locks across function calls.
authorMike Marshall <hubcap@omnibond.com>
Fri, 1 Jun 2018 18:17:23 +0000 (14:17 -0400)
committerMike Marshall <hubcap@omnibond.com>
Fri, 1 Jun 2018 18:51:49 +0000 (14:51 -0400)
Sparse complained and Al Viro knew what to do...

Signed-off-by: Mike Marshall <hubcap@omnibond.com>
fs/orangefs/waitqueue.c

index 0577d6dba8c81dc531f9ed027258f077c8a96ace..0729d2645d6af6ffef902546b67257ea8aa2b97d 100644 (file)
 #include "orangefs-kernel.h"
 #include "orangefs-bufmap.h"
 
-static int wait_for_matching_downcall(struct orangefs_kernel_op_s *, long, bool);
-static void orangefs_clean_up_interrupted_operation(struct orangefs_kernel_op_s *);
+static int wait_for_matching_downcall(struct orangefs_kernel_op_s *op,
+               long timeout,
+               bool interruptible)
+                       __acquires(op->lock);
+static void orangefs_clean_up_interrupted_operation(struct orangefs_kernel_op_s *op)
+       __releases(op->lock);
 
 /*
  * What we do in this function is to walk the list of operations that are
@@ -246,6 +250,7 @@ bool orangefs_cancel_op_in_progress(struct orangefs_kernel_op_s *op)
  */
 static void
        orangefs_clean_up_interrupted_operation(struct orangefs_kernel_op_s *op)
+               __releases(op->lock)
 {
        /*
         * handle interrupted cases depending on what state we were in when
@@ -313,8 +318,9 @@ static void
  * Returns with op->lock taken.
  */
 static int wait_for_matching_downcall(struct orangefs_kernel_op_s *op,
-                                     long timeout,
-                                     bool interruptible)
+               long timeout,
+               bool interruptible)
+                       __acquires(op->lock)
 {
        long n;