]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
net: dsa: Use sysfs_emit() to instead of sprintf()
authorBo Liu <liubo03@inspur.com>
Wed, 1 Feb 2023 08:14:38 +0000 (03:14 -0500)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 2 Feb 2023 14:28:59 +0000 (15:28 +0100)
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: Bo Liu <liubo03@inspur.com>
Link: https://lore.kernel.org/r/20230201081438.3151-1-liubo03@inspur.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/dsa/master.c

index 1507b8cdb3604015495cd13510138ab89b6eee51..22d3f16b0e6db22c4c3afce89e613e22f59c27ff 100644 (file)
@@ -299,7 +299,7 @@ static ssize_t tagging_show(struct device *d, struct device_attribute *attr,
        struct net_device *dev = to_net_dev(d);
        struct dsa_port *cpu_dp = dev->dsa_ptr;
 
-       return sprintf(buf, "%s\n",
+       return sysfs_emit(buf, "%s\n",
                       dsa_tag_protocol_to_str(cpu_dp->tag_ops));
 }