]> git.proxmox.com Git - pve-manager.git/commitdiff
fix: #1145 enable CT/VM firewall by default on creation via WebUI
authorChristian Ebner <c.ebner@proxmox.com>
Wed, 3 Apr 2019 07:26:32 +0000 (09:26 +0200)
committerDominik Csapak <d.csapak@proxmox.com>
Wed, 3 Apr 2019 09:25:25 +0000 (11:25 +0200)
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
www/manager6/lxc/Network.js
www/manager6/qemu/HardwareView.js
www/manager6/qemu/NetworkEdit.js

index 88c6e561020c477c4e5b31ad7be882a081fe0e66..1e11539dc4ac018c0d469be2b007f65243145da1 100644 (file)
@@ -56,6 +56,7 @@ Ext.define('PVE.lxc.NetworkInputPanel', {
            cdata.name = 'eth0';
            me.dataCache = {};
        }
+       cdata.firewall =  (me.insideWizard || me.isCreate);
 
        if (!me.dataCache) {
            throw "no dataCache specified";
index bfa06927adf561fd399ef7f443f0703570b16857..ba588e3751d3040a09f0e98ab569835baf72ae5d 100644 (file)
@@ -638,7 +638,8 @@ Ext.define('PVE.qemu.HardwareView', {
                                handler: function() {
                                    var win = Ext.create('PVE.qemu.NetworkEdit', {
                                        url: '/api2/extjs/' + baseurl,
-                                       pveSelNode: me.pveSelNode
+                                       pveSelNode: me.pveSelNode,
+                                       isCreate: true
                                    });
                                    win.on('destroy', reload);
                                    win.show();
index dd950d2bb461009bb421c10443adc612469e718a..abce4903c0f3e265fadc30dba6a3a34590d5dd17 100644 (file)
@@ -82,7 +82,8 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
            {
                xtype: 'proxmoxcheckbox',
                fieldLabel: gettext('Firewall'),
-               name: 'firewall'
+               name: 'firewall',
+               checked: (me.insideWizard || me.isCreate)
            }
        ];
 
@@ -185,7 +186,8 @@ Ext.define('PVE.qemu.NetworkEdit', {
 
        var ipanel = Ext.create('PVE.qemu.NetworkInputPanel', {
            confid: me.confid,
-           nodename: nodename
+           nodename: nodename,
+           isCreate: me.isCreate
        });
 
        Ext.applyIf(me, {