]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
misc: mic/scif: mark expected switch fall-through
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 26 Feb 2019 19:27:22 +0000 (13:27 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 Feb 2019 15:00:20 +0000 (16:00 +0100)
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/misc/mic/scif/scif_rma.c: In function ‘scif_unregister_window’:
drivers/misc/mic/scif/scif_rma.c:665:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
   send_msg = true;
   ~~~~~~~~~^~~~~~
drivers/misc/mic/scif/scif_rma.c:668:2: note: here
  case OP_IN_PROGRESS:
  ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/mic/scif/scif_rma.c

index 749321eb91ae1d50aa6853078f67501c0e2077ad..f62216628fa63883873304f52e3729241582affa 100644 (file)
@@ -672,8 +672,8 @@ int scif_unregister_window(struct scif_window *window)
        {
                window->unreg_state = OP_IN_PROGRESS;
                send_msg = true;
-               /* fall through */
        }
+               /* fall through */
        case OP_IN_PROGRESS:
        {
                scif_get_window(window, 1);